You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Forwarding signal handlers isn’t ideal because it introduces complexity and requires careful management of race conditions when restoring original handlers in multi-threaded environments.
A more robust approach would be using signal masking to block signals, as done in this PR: #616
However, we might not need to handle exit signals in MSGQSubSocket::receive() at all. We could instead delegate exit signal handling to the caller, following the approach in commaai/openpilot#32367 (closed by bot), where signal handling in params was removed entirely.
This basically never allows ExitHandler to see signals, needed for commaai/openpilot#32103
msgq/msgq/impl_msgq.cc
Lines 79 to 82 in 5bb86f8
The text was updated successfully, but these errors were encountered: