This repository has been archived by the owner on May 24, 2023. It is now read-only.
Add unit tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .eslintrc
…add_create_template_order
# Conflicts: # src/create-template-orders.js
ahmetoz
reviewed
Mar 7, 2022
| failedCheckoutOrders: 1, | ||
| duplicatedTemplateOrderCreation: 0, | ||
| }) | ||
| expect(createNewOrder.isDone()).to.be.true |
There was a problem hiding this comment.
this test is failing on my local, I think there is no retry in code 🤔
There was a problem hiding this comment.
Correct, check the description 😉
There was a problem hiding this comment.
OK do you know when it will be fixed ?
There was a problem hiding this comment.
No idea 🤷 I hope it will be soon 🤞
ahmetoz
approved these changes
Mar 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is one test failing? It's because I am testing retry on 500 error. This is currently being addressed in this PR: commercetools/nodejs#1764 by another team.