feat(http-error-retryCodes): improvement

- improve and refactor code
- add check to ensure retryCodes is not null

packages/sdk-middleware-http/src/http.js

@@ -95,6 +95,12 @@ export default function createHttpMiddleware({
     fetchFunction = fetch
   }
 
+  if (!Array.isArray(retryCodes)) {
+    throw new Error(
+      '`retryCodes` option must be an array of retry status (error) codes.'
+    )
+  }
+
   return (next: Next): Next =>
     (request: MiddlewareRequest, response: MiddlewareResponse) => {
       let abortController: any
@@ -232,7 +238,7 @@ export default function createHttpMiddleware({
 
               if (
                 enableRetry &&
-                (res.status === 503 || retryCodes.includes(res.status))
+                (res.status === 503 || (retryCodes?.indexOf(res.status) !== -1))
               ) {
                 if (retryCount < maxRetries) {
                   setTimeout(

packages/sdk-middleware-http/test/http.spec.js

@@ -45,6 +45,16 @@ describe('Http', () => {
     )
   })
 
+  test('throw when a non-array option is passed as retryCodes in the httpMiddlewareOptions', () => {
+    expect(() => {
+      createHttpMiddleware({ host: testHost, retryCodes: null, fetch })
+    }).toThrow(
+      new Error(
+        '`retryCodes` option must be an array of retry status (error) codes.'
+      )
+    )
+  })
+
   test('execute a get request (success)', () =>
     new Promise((resolve, reject) => {
       const request = createTestRequest({