[Draft] Refactor modal code #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchiu
commented
Sep 12, 2024
commit0/harness/run_pytest_ids.py
Outdated
| 3. Copies eval.sh from local to container. | ||
| 4. Runs evaluation and saves to {log_dir}/test_output.txt. | ||
| 5. Copies over report.json if it exists. | ||
| """ | ||
| import modal |
There was a problem hiding this comment.
tbh not sure why this was put inside the function, but i just followed suit with other imports
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factors out the modal code into a utility file