Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathmapper: don't use temporary lists #1949

Merged
merged 1 commit into from
Dec 1, 2023
Merged

pathmapper: don't use temporary lists #1949

merged 1 commit into from
Dec 1, 2023

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Dec 1, 2023

Should speed up items_exclude_children() a bit

@mr-c mr-c force-pushed the pathmapper_speedups branch from c0e6f1f to 967b114 Compare December 1, 2023 16:00
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9dff8c) 83.92% compared to head (d0f5abc) 83.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1949   +/-   ##
=======================================
  Coverage   83.92%   83.93%           
=======================================
  Files          46       46           
  Lines        8188     8190    +2     
  Branches     2175     2175           
=======================================
+ Hits         6872     6874    +2     
  Misses        844      844           
  Partials      472      472           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c mr-c force-pushed the pathmapper_speedups branch 2 times, most recently from 768447c to 026945e Compare December 1, 2023 16:54
Should speed up items_exclude_children() a bit
@mr-c mr-c force-pushed the pathmapper_speedups branch from 026945e to d0f5abc Compare December 1, 2023 16:57
@mr-c mr-c requested a review from tetron December 1, 2023 17:15
@mr-c
Copy link
Member Author

mr-c commented Dec 1, 2023

@gmloose (a toil-cwl-runner user with many inputs of large "measurement set" directories ) reported many hours to process stage_files and now reports that this PR reduces that to several minutes!

@mr-c mr-c merged commit 0250406 into main Dec 1, 2023
42 checks passed
@mr-c mr-c deleted the pathmapper_speedups branch December 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant