Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove galaxy-tool-util from build dependency #1955

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

jfennick
Copy link
Contributor

@jfennick jfennick commented Dec 8, 2023

Some of the build dependencies appear to be regular dependencies, and do not appear to be required at build time.
This may cause issues in certain specific situations. See this Dockerfile for a minimal reproducible example.
For now, this PR simply removes galaxy-tool-util from pyproject.toml (only).

FROM condaforge/miniforge3

# This works
# RUN conda install "python<3.10"

# Have to downgrade python to install pypy
RUN conda install "python<3.10" pypy

# Install binary system dependencies through conda (so we don't have to install compilers)
RUN conda install psutil

# This works
# RUN pip install cwltool

RUN conda install git
# Due to listing galaxy-tool-util as a build dependency,
# pip attempts to install conda-package-streaming and then zstandard from source and fails with:
# No such file or directory: 'cc'
RUN pip install cwltool@git+https://github.com/common-workflow-language/cwltool.git

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3404fd0) 83.79% compared to head (fea8bc1) 83.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1955   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          46       46           
  Lines        8231     8231           
  Branches     2186     2186           
=======================================
  Hits         6897     6897           
  Misses        858      858           
  Partials      476      476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It was required for typing reasons, but the cast seem to be sufficient.

@mr-c mr-c force-pushed the fix_build_dependencies branch from 369c462 to afc1bec Compare January 3, 2024 13:15
@mr-c mr-c enabled auto-merge (rebase) January 3, 2024 13:15
@mr-c mr-c force-pushed the fix_build_dependencies branch from afc1bec to 9fbc006 Compare January 3, 2024 15:41
@mr-c mr-c force-pushed the fix_build_dependencies branch from 9fbc006 to fea8bc1 Compare January 8, 2024 15:32
@mr-c mr-c merged commit 1eb83d1 into common-workflow-language:main Jan 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants