Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename singularity image #1956

Merged

Conversation

misterbrandonwalker
Copy link
Contributor

If user adds dockerImageId along with dockerFile , then rename the output image from spython Client.build accordingly

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a84911d) 83.84% compared to head (5d3b0bd) 82.40%.

Files Patch % Lines
cwltool/singularity.py 66.66% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1956      +/-   ##
==========================================
- Coverage   83.84%   82.40%   -1.44%     
==========================================
  Files          46       46              
  Lines        8219     8231      +12     
  Branches     2181     2186       +5     
==========================================
- Hits         6891     6783     -108     
- Misses        854      933      +79     
- Partials      474      515      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cwltool/singularity.py Outdated Show resolved Hide resolved
@mr-c mr-c force-pushed the singularity_image_name branch 2 times, most recently from 9d3aa41 to db65d54 Compare January 3, 2024 15:45
@mr-c mr-c enabled auto-merge (squash) January 8, 2024 12:21
@mr-c mr-c force-pushed the singularity_image_name branch from db65d54 to 5d3b0bd Compare January 8, 2024 12:21
@mr-c mr-c disabled auto-merge January 8, 2024 15:31
@mr-c mr-c merged commit 3404fd0 into common-workflow-language:main Jan 8, 2024
43 of 45 checks passed
@mr-c
Copy link
Member

mr-c commented Jan 8, 2024

Thank you @misterbrandonwalker !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants