Skip to content

Commit

Permalink
build: Remove unnecessary enabling of target property: MACOSX_RPATH
Browse files Browse the repository at this point in the history
According to CMake's documentation, MACOSX_RPATH is on already:

  https://cmake.org/cmake/help/latest/policy/CMP0042.html

Specifically:

  CMake 3.0 and later prefer this property to be ON by default.
  [This policy] may be set by cmake_policy() or cmake_minimum_required().
  If it is not set, CMake warns, and uses OLD behavior.

Well, the top-level 'CMakeLists.txt' already sets the minimum version:

  cmake_minimum_required(VERSION 3.7)

Therefore, it is unnecessary to enable it explicitly.
  • Loading branch information
mfwitten authored and jgm committed Apr 27, 2024
1 parent 2f31b3c commit e2bea4f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ add_library(cmark
xml.c)
cmark_add_compile_options(cmark)
set_target_properties(cmark PROPERTIES
MACOSX_RPATH TRUE
OUTPUT_NAME "cmark"
# Avoid name clash between PROGRAM and LIBRARY pdb files.
PDB_NAME libcmark
Expand Down

0 comments on commit e2bea4f

Please sign in to comment.