Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[437] Clang-Tidy: Narrowing conversion is implementation-defined #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[437] Clang-Tidy: Narrowing conversion is implementation-defined #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/blocks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ static void S_set_last_line_checked(cmark_node *node) {
node->flags |= CMARK_NODE__LAST_LINE_CHECKED;
}

static CMARK_INLINE bool S_is_line_end_char(char c) {
static CMARK_INLINE bool S_is_line_end_char(unsigned char c) {
return (c == '\n' || c == '\r');
}

static CMARK_INLINE bool S_is_space_or_tab(char c) {
static CMARK_INLINE bool S_is_space_or_tab(unsigned char c) {
return (c == ' ' || c == '\t');
}

Expand Down
12 changes: 6 additions & 6 deletions src/cmark_ctype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

/** 1 = space, 2 = punct, 3 = digit, 4 = alpha, 0 = other
*/
static const uint8_t cmark_ctype_class[256] = {
static const unsigned char cmark_ctype_class[256] = {
/* 0 1 2 3 4 5 6 7 8 9 a b c d e f */
/* 0 */ 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 0, 0,
/* 1 */ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All @@ -26,19 +26,19 @@ static const uint8_t cmark_ctype_class[256] = {
/**
* Returns 1 if c is a "whitespace" character as defined by the spec.
*/
int cmark_isspace(char c) { return cmark_ctype_class[(uint8_t)c] == 1; }
int cmark_isspace(unsigned char c) { return cmark_ctype_class[(uint8_t)c] == 1; }

/**
* Returns 1 if c is an ascii punctuation character.
*/
int cmark_ispunct(char c) { return cmark_ctype_class[(uint8_t)c] == 2; }
int cmark_ispunct(unsigned char c) { return cmark_ctype_class[(uint8_t)c] == 2; }

int cmark_isalnum(char c) {
int cmark_isalnum(unsigned char c) {
uint8_t result;
result = cmark_ctype_class[(uint8_t)c];
return (result == 3 || result == 4);
}

int cmark_isdigit(char c) { return cmark_ctype_class[(uint8_t)c] == 3; }
int cmark_isdigit(unsigned char c) { return cmark_ctype_class[(uint8_t)c] == 3; }

int cmark_isalpha(char c) { return cmark_ctype_class[(uint8_t)c] == 4; }
int cmark_isalpha(unsigned char c) { return cmark_ctype_class[(uint8_t)c] == 4; }
10 changes: 5 additions & 5 deletions src/cmark_ctype.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ extern "C" {
* We want cmark to behave the same no matter what the system locale.
*/

int cmark_isspace(char c);
int cmark_isspace(unsigned char c);

int cmark_ispunct(char c);
int cmark_ispunct(unsigned char c);

int cmark_isalnum(char c);
int cmark_isalnum(unsigned char c);

int cmark_isdigit(char c);
int cmark_isdigit(unsigned char c);

int cmark_isalpha(char c);
int cmark_isalpha(unsigned char c);

#ifdef __cplusplus
}
Expand Down