[cjk branch] Improve test cases #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tats-u
commented
Aug 24, 2024
•
tats-u
commented
- Remove some extra tests related to U+200B.
- Well-educated Japanese don't notate "こんにちは" (Hello or Good afternoon) as "こんにちわ". Replace the latter with the former. The "は" (ha) here is pronounced as "わ" (wa) but formally written as "は". I believe those who write "こんにちわ" are deserved to be looked down on. Typing “は” on a keyboard or smartphone is as easy as typing “わ”.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.