-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whilependingmerge #75
base: master
Are you sure you want to change the base?
Conversation
A few notes & learning experiences from doing this work: Check out ReCSS! It allows you to re-apply stylesheets without reloading the page. Its a big time-save and helps focus (no js distractions). http://david.dojotoolkit.org/recss.html when writing css, keep the selector rules as simple as possible. Sass is dangerous, indentation seems harmless but creates inflexible code. Only indent when necessary. Favor adding a new class to some existing markup than a new selector to some existing css. Try and be markup independent, referring only to a minimal set of class names. when deleting registration.rb, every method deleted was accompanied with a full-text-search In this javascript, there's about as much library code as there is procedural code. Try and logic and flow to a minimum and in one designated sector, with the rest being a toolbox that gets employed. (This also makes things more easy to test, automated or otherwise) And finally, I'm stoked because I got jquery.validate working with both client and server side errors and that's pretty cool. Go check out the code! It should be fun! |
9320072
to
77d6828
Compare
This still needs cross-browser testing, and some quick college i18n, but I figured I'd make a pull request just to kick things off.
Changes in these commits:
-- simplified sass, converted to erb, converted to coffee
-- created a file lib/javascripts/jquery-extensions. This holds certain custom tools such as $.fn.{disable, slideIn, nextInDom, fieldhelp, addSpinner, removeSpinner, submitAjax}. I recommend everyone take a look and make use of or add to this code when appropriate.
-- added public_api method which allows a class to bypass authorization
I should have some mpq updates on the way here shortly!