Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE main types like Point, Vector, Polyline are moved to compas na… #21

Merged
merged 1 commit into from
Jan 11, 2024
Merged

CHANGE main types like Point, Vector, Polyline are moved to compas na… #21

merged 1 commit into from
Jan 11, 2024

Conversation

petrasvestartas
Copy link
Contributor

@petrasvestartas petrasvestartas commented Jan 10, 2024

The main types like Point, Vector, Polyline and etc. are placed to the compas namespace because these names are very generic. For example if you want to run CGAL normal estimation, you get a clash with Windows Polyline class (the same name).

After the change, all the documentation example files were rerun to check if the compiled code works.

I am referring to compas.h main include header, most of the cpp files are modified due to this change:

...
namespace compas
{
    using Kernel = CGAL::Exact_predicates_inexact_constructions_kernel;
    using Point = Kernel::Point_3;
    using Vector = Kernel::Vector_3;
    using Polyline = std::vector<Point>;
    using Polylines = std::list<Polyline>;
    using Polyhedron = CGAL::Polyhedron_3<Kernel, CGAL::Polyhedron_items_with_id_3>;
    using Mesh = CGAL::Surface_mesh<Point>;
    using RowMatrixXd = Eigen::Matrix<double, Eigen::Dynamic, Eigen::Dynamic, Eigen::RowMajor>;
    using RowMatrixXi = Eigen::Matrix<int, Eigen::Dynamic, Eigen::Dynamic, Eigen::RowMajor>;$
...

@tomvanmele tomvanmele merged commit 3363f2a into compas-dev:main Jan 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants