Yakerize #4
Merged
Yakerize #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalocasas
approved these changes
Jan 27, 2025
| readme_path: str = None, | ||
| license_path: str = None, | ||
| version: str = None, | ||
| target_rhino: str = "rh8", |
There was a problem hiding this comment.
good point.. package manager allows minor version as well
There was a problem hiding this comment.
added support for minor version!
Comment on lines
+156
to
+157
| # not using `ctx.run()` here to get properly formatted output (unicode+colors) | ||
| os.system(f"{yak_exe_path} build --platform any") |
There was a problem hiding this comment.
does chdir have any effect if we don't use ctx.run()?
There was a problem hiding this comment.
mmh it appears so yea. yak packs the current directory. but wouldn't it though? chdir also just uses os
tomvanmele
reviewed
Jan 27, 2025
tomvanmele
approved these changes
Jan 27, 2025
|
👯 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of compas-dev/compas#1351.
Added task
yakerizeallowing the packaging of COMPAS packages as Grasshopper packages using YAK.This PR replaces compas-dev/compas-actions.ghpython_components#17 (might be used by the action in the future).
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.