Te server refactor 1 #1864
Merged
Te server refactor 1 #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevko
force-pushed
the
te-server-refactor-1
branch
from
4d2c6c6 to
acca6ce
Compare
| return isdup; | ||
| } | ||
|
|
||
| export { |
There was a problem hiding this comment.
Exporting everything twice is an anti-pattern. Determine which type of export to use for this module (default or non-default) and remove the other one.
.gitignore
Outdated
| .venv | ||
| jigsaw-vertex-integration-92ef30330cf7.json |
There was a problem hiding this comment.
seems oddly specific, but ok.
alternatively try a wildcard like jigsaw-vertex-integration*.json
|
FYI Pretty similar cypress failures when I run this branch locally: 
|
colinmegill
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating routes away from server.ts while deleting unused or commented out code