fix: don't add findings to result if none were generated

Signed-off-by: George Vauter <[email protected]>
complytime · Jan 30, 2025 · 5a24232 · 5a24232
1 parent 85567c7
commit 5a24232
Showing 1 changed file with 15 additions and 11 deletions.
diff --git a/framework/reporter.go b/framework/reporter.go
@@ -261,18 +261,22 @@ func (r *Reporter) GenerateAssessmentResults(ctx context.Context, planHref strin
 	}
 	reviewedConrols := r.findControls(*implementationSettings)
 
-	oscalResults := []oscalTypes.Result{
-		{
-			UUID:             uuid.NewUUID(),
-			Title:            "Automated Assessment Result",
-			Description:      "Assessment Results Automatically Genererated from PVP Results",
-			Start:            time.Now(),
-			ReviewedControls: reviewedConrols,
-			Observations:     &oscalObservations,
-			Findings:         &oscalFindings,
-		},
+	oscalResult := oscalTypes.Result{
+		UUID:             uuid.NewUUID(),
+		Title:            "Automated Assessment Result",
+		Description:      "Assessment Results Automatically Genererated from PVP Results",
+		Start:            time.Now(),
+		ReviewedControls: reviewedConrols,
+		Observations:     &oscalObservations,
+	}
+
+	if len(oscalFindings) > 0 {
+		oscalResult.Findings = &oscalFindings
+	}
+
+	assessmentResults.Results = []oscalTypes.Result{
+		oscalResult,
 	}
-	assessmentResults.Results = oscalResults
 
 	return assessmentResults, nil