Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a framework property to capture the CaC profile id #442

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add a framework property to capture the CaC profile id #442

wants to merge 3 commits into from
+53 −25

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Feb 5, 2025 •
edited
Loading

Description

Add a framework property to component definition control implementation during sync

Extras (small, separate commits):

  • Bumps trestle version to 3.7.0
  • Fix small typo in sync_cac_content_profile_task

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Updated unit test
  • Ensure the property is not overwritten by autofix or rules-transfrom

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 changed the title CPLYTM-462: add a framework property to capture the CaC profile id feat: add a framework property to capture the CaC profile id Feb 5, 2025
@jpower432
feat: adds framework property to control implementation
532c2fc 
To capture the original profile name in the CaC content,
a property is added to the control implementation that can
be used in complytime.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review February 6, 2025 15:59
hbraswelrh
hbraswelrh reviewed Feb 7, 2025
View reviewed changes
trestlebot/tasks/sync_cac_content_task.py
@@ -434,6 +440,16 @@ def _create_control_implementation(self) -> ControlImplementation:
all_implement_reqs.append(implemented_req)
ci.implemented_requirements = all_implement_reqs
self._add_set_parameters(ci)

# Add framework prop for complytime consumption. This should be the
# orginationing CaC profile name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit- just a spell check for originating

hbraswelrh
hbraswelrh approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@hbraswelrh hbraswelrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a minor comment :)

qduanmu
qduanmu approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@qduanmu qduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qduanmu qduanmu qduanmu approved these changes

@hbraswelrh hbraswelrh hbraswelrh approved these changes

@huiwangredhat huiwangredhat Awaiting requested review from huiwangredhat

@gvauter gvauter Awaiting requested review from gvauter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpower432 @qduanmu @hbraswelrh