it compiles #6
Merged
it compiles #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincheng96
force-pushed
the
jordan/and-on
branch
from
20399e0 to
f9072b8
Compare
kevincheng96
reviewed
Jun 7, 2024
fluffywaffles
force-pushed
the
jordan/and-on
branch
2 times, most recently
from
6863805 to
907ca6f
Compare
fluffywaffles
force-pushed
the
jordan/and-on
branch
from
907ca6f to
df61498
Compare
cwang25
reviewed
Jun 11, 2024
| string actionType; | ||
| bytes actionContext; | ||
| // One of the PAYMENT_METHOD_* constants. | ||
| string paymentMethod; |
There was a problem hiding this comment.
I guess we should put a TODO: for paymentMethod?
It seems I can't find where it gets initialized or specified anywhere 🤔
This constructs an Action struct for the Transfer flow. Tests are now passing. We also re-run the forge formatter using the version of foundry expected by CI. In fact, most of the diffs in this PR are formatter changes.
The gas snapshot CI action was failing because the project's `via-ir` settings were moved to a new Foundry profile, but our scripts and CI actions were not modified to use the Foundry profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had to rebase on main so that I had access to bridger code