Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin old version of Markupsafe #31

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Pin old version of Markupsafe #31

merged 1 commit into from
Mar 22, 2022

Conversation

dcsoto
Copy link
Collaborator

@dcsoto dcsoto commented Feb 25, 2022

New version of Markup safe breaks with old Jinja version. To work around it, an older version of Markupsafe needs to be manually added (manubot/rootstock#459). I added version 2.0.1 to the environment YAML (pallets/markupsafe#284).

New version of Markup safe breaks with old Jinja version. To work around it, an older version of Markupsafe needs to be manually added (manubot/rootstock#459). I added version 2.0.1 to the environment YAML (pallets/markupsafe#284).
@dcsoto
Copy link
Collaborator Author

dcsoto commented Mar 1, 2022

@BenjaSanchez can you check my PR? I hope it fixes an issue with the Markup rendering.

Copy link
Member

@BenjaSanchez BenjaSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delay. The fix works great and both my local setup + CI work :) Maybe at some point we should update our rootstock version, but for now let's just leave it as it is.

@dcsoto dcsoto merged commit 1e58973 into master Mar 22, 2022
@dcsoto dcsoto deleted the dcsoto-markupsafe branch March 22, 2022 02:06
@dcsoto dcsoto added bug Something isn't working manubot and removed bug Something isn't working labels Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants