Check required Conan version #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
memsharded
reviewed
May 18, 2023
memsharded
reviewed
May 18, 2023
|
Thanks for the feedback, I think it resulted in great improvements. Let me know if you see anything else! |
memsharded
approved these changes
May 19, 2023
ssrobins
force-pushed
the
check-conan-version
branch
from
f0e0788 to
7d39630
Compare
memsharded
approved these changes
May 21, 2023
|
Merged, thanks for your contribution! |
Thanks!! I can squash things down a bit next time, wasn't sure if that was going to be automatic or not. |
Not necessary, it was my bad. I usually have the "Squash & merge" Github button activated, but this time I didn't realize it was just merging without squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Conan version check so people don't get stuck trying to get this to work on an unsupported Conan version. Recently discussed in #512.
In addition to adding this functionality, I set up a rudimentary cmake unit test layer to validate Conan version parsing and version check scenarios. I see there's already some extensive test changes going on in #515, but I decided not to base this branch on that because it would make the diff harder to read. I did locate the tests in a
testssubdir to try to follow the pattern from that pull request.Look at the previous checks to see temporary breaks in the minimum version and the unit tests to prove they work and fail GitHub Actions.
Anyway, this is my first contribution to the repo so I'm still learning. As always, I'm open to changes to make it better and conform to the codebase!