Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] Allow apple-clang version 10 for nowide and C++ 11 #3977

Merged
merged 4 commits into from
Jan 20, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions recipes/boost/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def _min_compiler_version_default_cxx11(self):
return {
"gcc": 6,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default mode is C++98 for GCC versions prior to 6.1, and C++14 for GCC 6.1 and above.

Copy link
Contributor

@dmn-star dmn-star Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#Minimum compiler version having c++ standard >= 11 at 135

#Minimum compiler version uses c++ standard >= 11 by default

"clang": 6,
"apple-clang": 12, # guess
"apple-clang": 10,
uilianries marked this conversation as resolved.
Show resolved Hide resolved
"Visual Studio": 14, # guess
}.get(str(self.settings.compiler))

Expand All @@ -147,7 +147,7 @@ def _min_compiler_version_nowide(self):
return {
"gcc": 5,
"clang": 5,
"apple-clang": 12, # guess
Copy link
Contributor

@dmn-star dmn-star Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"apple-clang": 6,

"apple-clang": 10,
uilianries marked this conversation as resolved.
Show resolved Hide resolved
"Visual Studio": 14, # guess
}.get(str(self.settings.compiler))

Expand Down