Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: update to 1.77.0 (#6872) #6929

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

leha-bot
Copy link
Contributor

@leha-bot leha-bot commented Aug 19, 2021

Specify library name and version: boost/1.77.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

Bump Boost to 1.77.0. All deps have been updated by Python script rebuild-dependencies.py

The boost-mpi-check.patch has been rebased to 1.77.0 version.

Closes #6872, #7157.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@leha-bot leha-bot closed this Aug 19, 2021
@leha-bot leha-bot reopened this Aug 19, 2021
@conan-center-bot

This comment has been minimized.

@leha-bot
Copy link
Contributor Author

@jgsogo sorry for another mention; could you help with this weird CI error? 😊 The MacOS build has strangely failed (at first and second time)

@leha-bot leha-bot closed this Aug 20, 2021
@leha-bot leha-bot reopened this Aug 20, 2021
@conan-center-bot

This comment has been minimized.

@gummif
Copy link
Contributor

gummif commented Aug 20, 2021

Maybe related to opencv/opencv#14146, but have no idea where to apply that fix.

Maybe add to the test package CMakeLists (see https://skia.googlesource.com/external/github.com/libjpeg-turbo/libjpeg-turbo/+/refs/tags/1.5.90%5E%21/)

     if(APPLE)
       if(NOT CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG)
         set(CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG "-Wl,-rpath,")
       endif()
     endif()

@leha-bot
Copy link
Contributor Author

leha-bot commented Aug 20, 2021

Maybe related to opencv/opencv#14146, but have no idea where to apply that fix.

Maybe add to the test package CMakeLists (see https://skia.googlesource.com/external/github.com/libjpeg-turbo/libjpeg-turbo/+/refs/tags/1.5.90%5E%21/)

     if(APPLE)
       if(NOT CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG)
         set(CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG "-Wl,-rpath,")
       endif()
     endif()

It looks like the test_package's build failure, as the Boost is using Boost.Build (b2) for building yourself.
We could set this policy (CMP0068) in test_package's CMakeLists.txt, thanks for the idea 👍

It also seems that the MacOS image also uses the old CMake ( < 3.9)...

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

so the new dependencies-xxxxx.yml file is same as was for 1.76.0.

Did you run https://github.com/conan-io/conan-center-index/blob/365086d2c4164b27f6e89eb07fc165581d031527/recipes/boost/all/rebuild-dependencies.py?

@prince-chrismc
Copy link
Contributor

😖 Why are windows and macos coming as duplicate package ids?

-- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
DUPLICATED | boost/1.72.0 | 524ea35a8120baabdde02483add58d81bf541327 | Windows | Windows | x86_64 | x86_64 | Visual Studio | 14 | MT |   | Release |   | True |   |   |  
DUPLICATED | boost/1.72.0 | 524ea35a8120baabdde02483add58d81bf541327 | Macos | Macos | x86_64 | x86_64 | apple-clang | 10.0 |   | libc++ | Release |   | True  |   |  

//cc @madebr (our boost guru)

@madebr
Copy link
Contributor

madebr commented Aug 22, 2021

Thanks for the nomination @prince-chrismc.
The duplicated builds are no problem. They are the header-only boost version for Macos/Linux/Windows.

It looks like boost/1.72 is failing in the test package for arch=armv8 os=Macos.

CMake Error at build/9e9e53fc2b762590855e996df53de3efb6fd7fb9/Findlibbacktrace.cmake:39 (add_library):
  Attempting to use @rpath without CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG being
  set.  This could be because you are using a Mac OS X version less than 10.5
  or because CMake's platform configuration is corrupt.
Call Stack (most recent call first):
  build/9e9e53fc2b762590855e996df53de3efb6fd7fb9/FindBoost.cmake:1599 (conan_package_library_targets)
  CMakeLists.txt:20 (find_package)

I nominate @SpaceIm as he's our Apple go to guy.
All the errors have to do with libbacktrace. Perhaps something is wrong with that package?

@conan-center-bot

This comment has been minimized.

@dmn-star
Copy link
Contributor

My iOS/Catalyst/Android profiles have always looked like this.
...
boost:without_locale = True
boost:without_log = True
boost:without_stacktrace = True

I know that it is not a solution for cci, but I have never been able to build the boost with local/log/stacktrace.

@dmn-star
Copy link
Contributor

https://github.com/ianlancetaylor/libbacktrace
I couldn't see at a quick glance whether that supports ARM64 or not. Maybe disable the support for Arm64 (iOS/Catalyst/M1/Android) like for Windows. From the boost recipe

stacktrace_backtrace not supported on Windows
if self.settings.os == "Windows":
del self.options.with_stacktrace_backtrace

@SSE4
Copy link
Contributor

SSE4 commented Sep 2, 2021

https://github.com/ianlancetaylor/libbacktrace
I couldn't see at a quick glance whether that supports ARM64 or not. Maybe disable the support for Arm64 (iOS/Catalyst/M1/Android) like for Windows. From the boost recipe

it seems like ARM64 is supported in code to some degree: ianlancetaylor/libbacktrace@4e548e7#diff-76ce24fe823ff3c52a40864352cbd78278e3dbded9e905904f266feaf5aeca8aR760
I'll check it tomorrow and reply back

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Sep 3, 2021

I nominate @SpaceIm as he's our Apple go to guy.

Nice try, but I don't know 😄

@madebr
Copy link
Contributor

madebr commented Sep 3, 2021

I nominate @SpaceIm as he's our Apple go to guy.

Nice try, but I don't know 😄

Detective @SSE4 🕵️ is on the case.

@dmn-star
Copy link
Contributor

dmn-star commented Sep 4, 2021

https://github.com/ianlancetaylor/libbacktrace
I couldn't see at a quick glance whether that supports ARM64 or not. Maybe disable the support for Arm64 (iOS/Catalyst/M1/Android) like for Windows. From the boost recipe

it seems like ARM64 is supported in code to some degree: ianlancetaylor/libbacktrace@4e548e7#diff-76ce24fe823ff3c52a40864352cbd78278e3dbded9e905904f266feaf5aeca8aR760
I'll check it tomorrow and reply back

Do you have access to M1 Mac to verify this?

ps: google says swift-server/swift-backtrace#19

@leha-bot If you want to close multiple issues at once use full syntax for each issue
Closes #6872, closes #7157

@SSE4
Copy link
Contributor

SSE4 commented Sep 4, 2021

Do you have access to M1 Mac to verify this?

unfortunately I don't have access. at least, it cross-compiles successfully, but I can't run any tests.
also, there are aarch64 packages for libbacktrace in several distros, so I believe it works.

@SSE4 SSE4 closed this Sep 10, 2021
@SSE4 SSE4 reopened this Sep 10, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 9 (8a5cd5a4ebfea91da01f9563022029ec967334fa):

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

@madebr
Copy link
Contributor

madebr commented Sep 10, 2021

Why did c3i build all combinations?
Isn't building only 1.77.0 enough?

@SSE4
Copy link
Contributor

SSE4 commented Sep 10, 2021

Why did c3i build all combinations?
Isn't building only 1.77.0 enough?

good question... recipe has:

exports_sources = ['patches/*']

and commit adds a new patch. even if it's not used by the old versions, I guess it's still exported and considered as a part of recipe revision?

@madebr
Copy link
Contributor

madebr commented Sep 10, 2021

That makes sense.

@SSE4 SSE4 requested a review from uilianries September 10, 2021 19:36
@conan-center-bot conan-center-bot merged commit 1020df5 into conan-io:master Sep 10, 2021
@madebr madebr mentioned this pull request Sep 10, 2021
4 tasks
@leha-bot leha-bot deleted the update/boost-1-77 branch September 14, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] boost/1.77.0
9 participants