Fix art:build-info create for recipe-only dependencies #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing the same issue in our project as in #166
I think the problem is that some dependencies are recipe-only, like this one for example:
Click to expand JSON
Notice how the
recipe_folder
field has a value butpackage_folder
doesn't.get_artifacts()
was called on it twice, here and here. The first call succeeded since the node had arecipe_folder
value, but the second failed because it doesn't have apackage_folder
value.I added a check to see if these values exist so that
get_artifacts()
only gets called when it's expected to return meaningful values.