-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux - Conan prev-prev is allowed to fail #77
base: master
Are you sure you want to change the base?
Linux - Conan prev-prev is allowed to fail #77
Conversation
Signed-off-by: Uilian Ries <[email protected]>
I am not sure about this change. Maybe we want to know that it fails in order to fix conan develop as soon as possible. In the case we want to avoid develop, I'd rather remove it from the CI. WDYT @jgsogo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is important to keep this check... and realize that a commit to Conan repository broke the example. If we are breaking an example there are two options:
- We have introduced a regression in Conan
- The example was not using stable features from Conan
- (recipe in ConanCenter changed and we need to update the example)
All of them, IMHO, manifest a problem that should be fixed ASAP.
What is the scenario we want to bypass here?
The latest failed build on master branch (2 days ago): https://travis-ci.org/github/conan-io/examples/jobs/756008647 It reports both Folly and Imgur can not be installed, because requires Conan 1.32. That's correct, but prev-prev:
We could remove Folly or even disable, but when 1.34.0 be available, 1.32 will be prev-prev and acceptable for Folly. |
In that case, maybe we should add something as we do with I mean, instead of thinking about something like this (which is needed in case of new features) Line 57 in e8c84db
we can add a Line 195 in e8c84db
Does it make sense? |
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! And the CI will like it too 😄
I can't see any error on AppVeyor. Timeout maybe? Restarting ... |
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
.travis.yml
Outdated
@@ -7,8 +7,8 @@ jobs: | |||
include: | |||
|
|||
- stage: Linux - Conan develop | |||
name: Python 3.5 | |||
python: 3.5 | |||
name: Python 3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subprocess.run
is Python 3.5, but it doesn't work here, probably the patch version is incompatible. https://docs.python.org/3.5/library/subprocess.html#subprocess.run
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
There is a reason to use lower Python 3.6 (we can move away from 3.5, but let's keep it at 3.6): https://github.com/conan-io/tribe/blob/main/design/003-codebase-python.md The plan is to move this CI (and the rest) to our Jenkins now that @czoido has migrated Conan-TestSuite. If it is broken in Appveyor/Travis, we can focus on moving to our CI and then take care of this issue. |
I agree, I'll change to support 3.5 again |
@uilianries Python 3.6 is enough (if 3.5 fails for any reason) |
Signed-off-by: Uilian Ries <[email protected]>
@jgsogo It's totally possible emulate |
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
After many tries, our current villain is brew upgrade pyenv command. Travis takes more than 50 minutes only to run As OSX build are a pain in the neck for us, we could migrate Example to Jenkins. WDYT @jgsogo @danimtb ? |
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
The CI job conanprevprev is unstable, it fails frequently because runs Conan's Development.The CI job conanprevprev is unstable, it fails frequently because runs old old conan version, which is not required by some recipes.
It should not be considered as an important branch here, as all features are not matured.