mitigate blinking css due to utopia bug #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanparsons
approved these changes
Oct 16, 2024
ruggi
approved these changes
Oct 16, 2024
Rheeseyb
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bug in utopia which leads to the remix scene remounting during an interaction. After the remount happens, if we are in an active interaction session, only the interacted-with elements are allowed to re-render, which means we don't rerender the remix roots, which means this CSS has no chance to mount itself back to the canvas.
The mitigation is to also import the css in storyboard.js which doesn't have the remount bug. This fully stops the blinking from happening.
The remount is still happening and the utopia bug must be fixed, but in the interim, at least we can continue using the demo project.