Skip to content

Commit

Permalink
chore(types): remove duplicate type definitions (#6477)
Browse files Browse the repository at this point in the history
**Problem:**
Today we have shared types between the editor and our Remix code
(`utopia-shared`), however some of these definitions are still
duplicated in the editor code (even if identical), which can lead to
divergence over time.

**Fix:**
Make sure the duplicated types are identical and remove them, reference
`utopia-shared` as the source of truth.
Actual code (functions) was not moved, only types, since `utopia-shared`
should be kept separated from editor code and imports.

**Note:**
In the future this can allow us to have `utopia-shared` code hash (or
package version) as the cache version for `ParseSuccess` objects.

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode
  • Loading branch information
liady authored Oct 7, 2024
1 parent d293134 commit 3b167ce
Show file tree
Hide file tree
Showing 2 changed files with 111 additions and 252 deletions.
Loading

0 comments on commit 3b167ce

Please sign in to comment.