Skip to content

Commit

Permalink
Keep span when reordering grid items (#6642)
Browse files Browse the repository at this point in the history
**Problem:**

Spans (or otherwise 1+ sized elements) are not preserved when using
`gridReorderStrategy`.

**Fix:**

When running the reorder strategy, instead of nuking all positioning
props only nuke the ones which are not used and, for elements that
occupy multiple cells, set the respective width or height using the
`span` syntax on the correct shorthand.

I also took this chance to move the reorder tests to their own file (and
added the new tests there).

Fixes #6641
  • Loading branch information
ruggi authored and liady committed Dec 13, 2024
1 parent ffa24f6 commit 465950e
Show file tree
Hide file tree
Showing 4 changed files with 796 additions and 616 deletions.
Loading

0 comments on commit 465950e

Please sign in to comment.