Early return was wrong

concrete-utopia · Jul 15, 2024 · 81de9c0 · 81de9c0
1 parent 247d8b9
commit 81de9c0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/editor/src/components/canvas/ui-jsx-canvas-renderer/ui-jsx-canvas-component-renderer.tsx b/editor/src/components/canvas/ui-jsx-canvas-renderer/ui-jsx-canvas-component-renderer.tsx
@@ -387,10 +387,6 @@ function isRenderProp(prop: any): prop is { props: { [UTOPIA_PATH_KEY]: string }
 }
 
 function areElementsInChildrenOrPropsTree(elementPaths: Array<string>, props: any): boolean {
-  if (props.children == null || typeof props.children === 'string') {
-    return false
-  }
-
   const childrenArr = fastReactChildrenToArray(props.children)
 
   for (let c of childrenArr) {
@@ -420,6 +416,9 @@ function areElementsInChildrenOrPropsTree(elementPaths: Array<string>, props: an
 }
 
 function fastReactChildrenToArray(children: any) {
+  if (children == null || typeof children === 'string') {
+    return []
+  }
   if (React.isValidElement(children)) {
     return [children]
   }