Skip to content

Commit

Permalink
Adjust component prop metadata labels (#5569)
Browse files Browse the repository at this point in the history
* adjust coloring

* connected to data

* use `controlled`

* always pointer
  • Loading branch information
ruggi authored May 5, 2024
1 parent 4defc57 commit 9da7f27
Showing 1 changed file with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ const RowForBaseControl = React.memo((props: RowForBaseControlProps) => {
setIsHovered(false)
}

const isValueSet = React.useMemo(() => {
return propMetadata.propertyStatus.set
const isConnectedToData = React.useMemo(() => {
return propMetadata.propertyStatus.controlled
}, [propMetadata])

const propertyLabel =
Expand All @@ -415,22 +415,25 @@ const RowForBaseControl = React.memo((props: RowForBaseControlProps) => {
alignItems: 'center',
gap: 6,
color:
dataPickerButtonData.popupIsOpen || isHovered || !isValueSet
dataPickerButtonData.popupIsOpen || isHovered || isConnectedToData
? colorTheme.dynamicBlue.value
: undefined,
cursor: 'pointer',
}}
>
{title}
<div
style={{
opacity: isHovered || dataPickerButtonData.popupIsOpen || !isValueSet ? 1 : 0,
opacity: isHovered || dataPickerButtonData.popupIsOpen ? 1 : 0,
}}
>
<Icn
category='semantic'
type='plus-in-white-translucent-circle'
color={
dataPickerButtonData.popupIsOpen || isHovered || !isValueSet ? 'dynamic' : 'main'
dataPickerButtonData.popupIsOpen || isHovered || !isConnectedToData
? 'dynamic'
: 'main'
}
width={12}
height={12}
Expand Down

0 comments on commit 9da7f27

Please sign in to comment.