New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for list children, add the number to the navigator #5961

Closed

maltenuhn opened this issue Jun 17, 2024 · 0 comments · Fixed by #5968

Assignees

Member

maltenuhn commented Jun 17, 2024 •

edited

Loading

Problem
It's kinda hard to understand what list children are, and how they related to what's on the canvas

Partial solution
Immediate list children get an index number prefix, before the icon

Implementation hints

Container becomes relative / origin-giving
use the coordinates and font characteristics in the screenshot for positioning.
Also (not shown) add text-align right, so any (rare) multi-digit numbers extend to the left instead of the right
Ensure font color matches the label (believe that's the case by default through a generous inheritance, but verify)
use human numbering (starting at 1 not 0)

gbalint self-assigned this

gbalint mentioned this issue

List index in navigator #5968

Merged

2 tasks

gbalint added a commit that referenced this issue


          List index in navigator (#5968)

42a8476

**Problem:**
For list children, add a number to the navigator item, see
#5961

<img width="138" alt="image"
src="https://github.com/concrete-utopia/utopia/assets/127662/6b6cdc97-9607-4be6-b347-1ae63bdc38bc">


**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Preview mode

Fixes #5961

gbalint closed this as completed in #5968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment