Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List index in navigator #5968

Merged
merged 3 commits into from
Jun 17, 2024
Merged

List index in navigator #5968

merged 3 commits into from
Jun 17, 2024

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Jun 17, 2024 •
edited
Loading

Problem:
For list children, add a number to the navigator item, see #5961

image

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #5961

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jun 17, 2024

#13096 Bundle Size — 62.22MiB (~+0.01%).

0fea544(current) vs 6339ece master#13094(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13096		      Baseline
#13094
Regression  Initial JS 45.29MiB(~+0.01%) 45.28MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.56% 21.55%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4302 4302
No change  Duplicate Modules 523 523
No change  Duplicate Code 31.84% 31.84%
No change  Packages 448 448
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13096		      Baseline
#13094
Regression  JS 62.21MiB (~+0.01%) 62.21MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis report Branch feature/list-index-in-navigator Project dashboard

@gbalint gbalint merged commit 42a8476 into master Jun 17, 2024
13 checks passed
@gbalint gbalint deleted the feature/list-index-in-navigator branch June 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@ruggi ruggi ruggi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

for list children, add the number to the navigator
4 participants
@gbalint @ruggi @balazsbajorics @bkrmendy