Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support dynamic grid repeats #6402

Closed
ruggi opened this issue Sep 23, 2024 · 0 comments · Fixed by #6403
Closed

support dynamic grid repeats #6402

ruggi opened this issue Sep 23, 2024 · 0 comments · Fixed by #6403
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Sep 23, 2024

No description provided.

@ruggi ruggi self-assigned this Sep 23, 2024
@ruggi ruggi mentioned this issue Sep 23, 2024
Merged
ruggi added a commit that referenced this issue Sep 24, 2024
@ruggi
Support parsing dynamic repeats (#6403)
627769a 
**Problem:**

Dynamic `repeat` functions in grid templates (e.g. `repeat(auto-fill,
...)` are not supported.

**Fix:**

1. Extend the repeat functions to allow supported keywords in the
`times` parsing, so they are preserved when serializing templates
2. …but disable resizing templates that show them, because it can be
impossible to derive their count from the computed style. We might
revisit this in the future, though.

Fixes #6402
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Support parsing dynamic repeats (#6403)
af40a6f 
**Problem:**

Dynamic `repeat` functions in grid templates (e.g. `repeat(auto-fill,
...)` are not supported.

**Fix:**

1. Extend the repeat functions to allow supported keywords in the
`times` parsing, so they are preserved when serializing templates
2. …but disable resizing templates that show them, because it can be
impossible to derive their count from the computed style. We might
revisit this in the future, though.

Fixes #6402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support parsing dynamic repeats concrete-utopia/utopia
1 participant
@ruggi