Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing dynamic repeats #6403

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Support parsing dynamic repeats #6403

merged 5 commits into from
Sep 24, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Sep 23, 2024

Problem:

Dynamic repeat functions in grid templates (e.g. repeat(auto-fill, ...) are not supported.

Fix:

  1. Extend the repeat functions to allow supported keywords in the times parsing, so they are preserved when serializing templates
  2. …but disable resizing templates that show them, because it can be impossible to derive their count from the computed style. We might revisit this in the future, though.

Fixes #6402

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Try me

Copy link

relativeci bot commented Sep 23, 2024

#14337 Bundle Size — 62.67MiB (~+0.01%).

2a6c910(current) vs 916e8b9 master#14327(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14337
     Baseline
#14327
Regression  Initial JS 45.79MiB(~+0.01%) 45.79MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 22.37% 21.75%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4383 4383
No change  Duplicate Modules 520 520
No change  Duplicate Code 31.62% 31.62%
No change  Packages 472 472
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14337
     Baseline
#14327
Regression  JS 62.66MiB (~+0.01%) 62.65MiB
Improvement  HTML 11.12KiB (-0.32%) 11.16KiB

Bundle analysis reportBranch feat/grid-auto-fillProject dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi merged commit 627769a into master Sep 24, 2024
14 checks passed
@ruggi ruggi deleted the feat/grid-auto-fill branch September 24, 2024 13:31
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**

Dynamic `repeat` functions in grid templates (e.g. `repeat(auto-fill,
...)` are not supported.

**Fix:**

1. Extend the repeat functions to allow supported keywords in the
`times` parsing, so they are preserved when serializing templates
2. …but disable resizing templates that show them, because it can be
impossible to derive their count from the computed style. We might
revisit this in the future, though.

Fixes #6402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support dynamic grid repeats
3 participants