-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing dynamic repeats #6403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14337 Bundle Size — 62.67MiB (~+0.01%).2a6c910(current) vs 916e8b9 master#14327(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
Current #14337 |
Baseline #14327 |
|
---|---|---|
Initial JS | 45.79MiB (~+0.01% ) |
45.79MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 22.37% |
21.75% |
Chunks | 30 |
30 |
Assets | 33 |
33 |
Modules | 4383 |
4383 |
Duplicate Modules | 520 |
520 |
Duplicate Code | 31.62% |
31.62% |
Packages | 472 |
472 |
Duplicate Packages | 70 |
70 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #14337 |
Baseline #14327 |
|
---|---|---|
JS | 62.66MiB (~+0.01% ) |
62.65MiB |
HTML | 11.12KiB (-0.32% ) |
11.16KiB |
Bundle analysis report Branch feat/grid-auto-fill Project dashboard
Generated by RelativeCI Documentation Report issue
seanparsons
reviewed
Sep 24, 2024
seanparsons
approved these changes
Sep 24, 2024
liady
approved these changes
Sep 24, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Dynamic `repeat` functions in grid templates (e.g. `repeat(auto-fill, ...)` are not supported. **Fix:** 1. Extend the repeat functions to allow supported keywords in the `times` parsing, so they are preserved when serializing templates 2. …but disable resizing templates that show them, because it can be impossible to derive their count from the computed style. We might revisit this in the future, though. Fixes #6402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Dynamic
repeat
functions in grid templates (e.g.repeat(auto-fill, ...)
are not supported.Fix:
times
parsing, so they are preserved when serializing templatesFixes #6402