Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useEffect from FollowingOverlay #4513

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Remove useEffect from FollowingOverlay #4513

merged 3 commits into from
Nov 20, 2023

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Nov 20, 2023

Fixes #4512

This PR removes the useEffect in FollowingOverlay replacing it with Others callbacks.

It also renames const self = useSelf to const me = useSelf.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Nov 20, 2023

Job #9217: Bundle Size — 65.58MiB (+0.65%).

b1d8190(current) vs 5957b21 master#9215(baseline)

Warning

Bundle contains 67 duplicate packages – View duplicate packages

Warning

Bundle introduced 4 new packages: yjs, lib0, @liveblocks/yjs and one more – View changed packages

Bundle metrics  Change 5 changes Regression 2 regressions Improvement 1 improvement
                 Current
Job #9217		      Baseline
Job #9215
Regression  Initial JS 47.73MiB(+0.9%) 47.3MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.1% 25.02%
No change  Chunks 25 25
No change  Assets 29 29
Change  Modules 4420(+0.73%) 4388
No change  Duplicate Modules 469 469
Improvement  Duplicate Code 30.17%(-0.66%) 30.37%
Regression  Packages 458(+0.88%) 454
No change  Duplicate Packages 67 67
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9217		      Baseline
Job #9215
Regression  JS 65.57MiB (+0.65%) 65.14MiB
Not changed  HTML 11.32KiB 11.32KiB

View job #9217 report View fix/multiplayer-follow-useeffect branch activity

balazsbajorics
balazsbajorics approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@balazsbajorics balazsbajorics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice!

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit aca6ae6 into master Nov 20, 2023
@ruggi ruggi deleted the fix/multiplayer-follow-useeffect branch November 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanparsons seanparsons seanparsons approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove useEffect from FollowingOverlay
3 participants
@ruggi @seanparsons @balazsbajorics