Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent context menus #5565

Merged
merged 9 commits into from
May 5, 2024
Merged

Consistent context menus #5565

merged 9 commits into from
May 5, 2024

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented May 5, 2024

  1. Making the Quick Component Picker and Full Component Picker (the one behind MORE...) visually consistent (spacing, gaps, highlights, etc). TABLESS . The background colors are slightly different so that it still contrasts with the default bg color in dark theme.
  2. Making the Data Picker visually consistent with those two (same box shadow, same dark bg, same blue highlight, same icon - label spacing
  3. Making the context menu styling visually consistent with those two (padding, box shadow, row spacing etc)
  4. Using tabs in the Data Picker instead of the popup menu because the popup menu is theme-aware, and the context menu should not be - so there was no simple way to edit the style of the popup menu without changing it in the whole app. If we don't want to show these filter options at all yet we can get rid of these tabs entirely.

Fixes #[5459]

Dark:
data-picker
Screenshot 2024-05-05 at 1 19 16 AM
Screenshot 2024-05-05 at 1 18 26 AM
Screenshot 2024-05-05 at 1 18 40 AM

Light:
Screenshot 2024-05-05 at 1 56 26 AM
Screenshot 2024-05-05 at 1 22 58 AM
Screenshot 2024-05-05 at 1 57 07 AM
Screenshot 2024-05-05 at 1 57 16 AM

Copy link
Contributor

github-actions bot commented May 5, 2024

Try me

Copy link

relativeci bot commented May 5, 2024

#12258 Bundle Size — 62.48MiB (~-0.01%).

ef8a994(current) vs 6339ece master#12256(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#12258
     Baseline
#12256
Improvement  Initial JS 45.55MiB(-0.01%) 45.56MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.76% 21.06%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4377 4377
No change  Duplicate Modules 504 504
No change  Duplicate Code 30.81% 30.81%
No change  Packages 468 468
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#12258
     Baseline
#12256
Improvement  JS 62.47MiB (~-0.01%) 62.47MiB
Improvement  HTML 10.94KiB (-0.34%) 10.98KiB

Bundle analysis reportBranch consistent-context-menusProject dashboard

Copy link
Contributor

github-actions bot commented May 5, 2024

Performance test results:
(Chart1)
(Chart2)

@lankaukk lankaukk marked this pull request as ready for review May 5, 2024 06:02
maltenuhn and others added 2 commits May 5, 2024 15:44
@lankaukk lankaukk merged commit 312fbd8 into master May 5, 2024
13 checks passed
@lankaukk lankaukk deleted the consistent-context-menus branch May 5, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants