Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some cartouche icon problems #5962

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

balazsbajorics
Copy link
Contributor

Problem:
image
some array literals were shown with the broken image icon

and

image directly after insertion, we'd show a broken image icon for a bit and then show the real icon

Commit Details:

  • For "unknown" data, Instead of ever again showing the broken image icon, show a 12x12 invisible div, so the cartouche layout doesn't fall apart and we are not showing ? or anything that would look weird on video or screenshots
  • Actually for array literals such as [1, 2, 3] do not show the 'unknown' icon because we know this to be an array!

Fixes #5960

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Try me

Copy link

relativeci bot commented Jun 17, 2024

#13090 Bundle Size — 62.22MiB (~+0.01%).

09a61f9(current) vs 6339ece master#13086(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13090
     Baseline
#13086
Regression  Initial JS 45.28MiB(~+0.01%) 45.28MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.56% 21.54%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4302 4302
No change  Duplicate Modules 523 523
No change  Duplicate Code 31.84% 31.84%
No change  Packages 448 448
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13090
     Baseline
#13086
Regression  JS 62.21MiB (~+0.01%) 62.21MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch fix/cartouche-icon-problemsProject dashboard

@balazsbajorics balazsbajorics merged commit 3c81b55 into master Jun 17, 2024
13 checks passed
@balazsbajorics balazsbajorics deleted the fix/cartouche-icon-problems branch June 17, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly created List has missing icon
3 participants