Feautre/cartouche context menu #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13132 Bundle Size — 62.24MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13132 |
Baseline #13129 |
|
|---|---|---|
 Initial JS |
45.3MiB(~+0.01%) |
45.3MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.21% |
21.57% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4302 |
4302 |
| Duplicate Modules |
523 |
523 |
| Duplicate Code |
31.83%(-0.03%) |
31.84% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13132 |
Baseline #13129 |
|
|---|---|---|
| JS |
62.23MiB (~+0.01%) |
62.23MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feautre/cartouche-context-menu Project dashboard
bkrmendy
approved these changes
Jun 19, 2024
seanparsons
reviewed
Jun 19, 2024
| @@ -127,7 +127,7 @@ describe('React Render Count Tests -', () => { | |||
|
|
|||
| const renderCountAfter = renderResult.getNumberOfRenders() | |||
| // if this breaks, GREAT NEWS but update the test please :) | |||
| expect(renderCountAfter - renderCountBefore).toMatchInlineSnapshot(`1007`) | |||
There was a problem hiding this comment.
That seems like quite a jump.
seanparsons
approved these changes
Jun 19, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
This PR adds a basic context menu to the Data Reference Cartouche. <img width="315" alt="image" src="https://github.com/concrete-utopia/utopia/assets/2226774/a4f57aae-cc2c-4fce-8389-376e28d3a68c"> Most of my evening was spent wrestling ContextMenuWrapper. I decided to "give up" and create a new component which uses a proper portal instead of horrible x-hacks and whatevers. **Commit Details:** - Renamed `ContextMenuWrapper` to `ContextMenuWrapper_DEPRECATED` also marked it as deprecated - Added new `ContextMenuWrapper` which takes way less props, uses less wrapping divs, and uses a Portal. - `DataCartoucheInner` uses `ContextMenuWrapper`. - The only actually working option is `Replace...` which just opens the data picker - Everything else is a placeholder for future capability Fixes #5972 --------- Co-authored-by: Berci Kormendy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic context menu to the Data Reference Cartouche.
Most of my evening was spent wrestling ContextMenuWrapper. I decided to "give up" and create a new component which uses a proper portal instead of horrible x-hacks and whatevers.
Commit Details:
ContextMenuWrappertoContextMenuWrapper_DEPRECATEDalso marked it as deprecatedContextMenuWrapperwhich takes way less props, uses less wrapping divs, and uses a Portal.DataCartoucheInnerusesContextMenuWrapper.Replace...which just opens the data pickerFixes #5972