Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gap & padding control default values #5997

Closed
wants to merge 1 commit into from

Conversation

bkrmendy
Copy link
Contributor

Problem

#5981

The padding and gap controls are not resilient to tailwind classes

Fix

Make the padding and gap controls always fall back to the values coming from the actual DOM measurements if they can't read the appropriate values from the style prop (because it's not there)

Manual Tests

I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Try me

Copy link

relativeci bot commented Jun 19, 2024

#13131 Bundle Size — 62.24MiB (~+0.01%).

69ddb6a(current) vs 6339ece master#13129(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13131
     Baseline
#13129
Regression  Initial JS 45.3MiB(~+0.01%) 45.3MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.58% 21.57%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4302 4302
No change  Duplicate Modules 523 523
No change  Duplicate Code 31.84% 31.84%
No change  Packages 448 448
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13131
     Baseline
#13129
Regression  JS 62.23MiB (~+0.01%) 62.23MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch fix/gap-padding-tailwindProject dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant