Standardise Handling Of Scrubbing In The Inspector #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In `FlexGapControl` remove the increment buttons and move the label inside so it can be scrubbed. - Fixed the handling of the prior values upon which the movement is calculated in `FrameUpdatingLayoutControl`. - Set step size to 1 in `FrameUpdatingLayoutControl`. - Removed increment controls from `BorderSubSection`. - Removed increment controls and set step size to 0.1 in `ShadowSubsection`. - Removed increment controls and set step size to 0.1 in `TextShadowSubsec - Removed increment controls and set step size to 0.1 in `TransformSubsection`. - Added `onMouseDown` handler to inner label of `NumberInput`.
#13144 Bundle Size — 62.26MiB (+0.02%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13144 |
Baseline #13140 |
|
|---|---|---|
 Initial JS |
45.32MiB(+0.03%) |
45.31MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
40.71% |
22.66% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4305(+0.07%) |
4302 |
| Duplicate Modules |
525(+0.38%) |
523 |
| Duplicate Code |
31.84% |
31.84% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13144 |
Baseline #13140 |
|
|---|---|---|
| JS |
62.24MiB (+0.02%) |
62.23MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feature/inspector-input-scrubbin... Project dashboard
seanparsons
requested review from
gbalint,
ruggi,
balazsbajorics,
liady and
bkrmendy
bkrmendy
approved these changes
Jun 19, 2024
ruggi
approved these changes
Jun 19, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
- In `FlexGapControl` remove the increment buttons and move the label inside so it can be scrubbed. - Fixed the handling of the prior values upon which the movement is calculated in `FrameUpdatingLayoutControl`. - Set step size to 1 in `FrameUpdatingLayoutControl`. - Removed increment controls from `BorderSubSection`. - Removed increment controls and set step size to 0.1 in `ShadowSubsection`. - Removed increment controls and set step size to 0.1 in `TextShadowSubsection`. - Removed increment controls and set step size to 0.1 in `TransformSubsection`. - Added `onMouseDown` handler to inner label of `NumberInput`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We want to make the following changes to the number inputs:
Fix:
Mostly these changes have involved just applying the right properties to the
NumberInputcontrols.However one part that needed changing a tiny bit beyond that was a fix to
FrameUpdatingLayoutControl, the common prior value was being stored in the event handler closure. But it needed to be recalculated as the value changes while scrubbing through them.Commit Details:
FlexGapControlremove the increment buttons and move the label inside so it can be scrubbed.FrameUpdatingLayoutControl.FrameUpdatingLayoutControl.BorderSubSection.ShadowSubsection.TextShadowSubsection.TransformSubsection.onMouseDownhandler to inner label ofNumberInput.Manual Tests:
I hereby swear that:
Further addresses #5869.