Add Manage Panels to Toolbar #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13183 Bundle Size — 62.26MiB (~-0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13183 |
Baseline #13177 |
|
|---|---|---|
 Initial JS |
45.32MiB(~-0.01%) |
45.32MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.84% |
21.58% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4306(+0.02%) |
4305 |
| Duplicate Modules |
525 |
525 |
| Duplicate Code |
31.84% |
31.84% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 2 improvements
| Current #13183 |
Baseline #13177 |
|
|---|---|---|
| JS |
62.24MiB (~-0.01%) |
62.24MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch panels-manager Project dashboard
benwolfram
force-pushed
the
panels-manager
branch
from
ccb06b7 to
a1b8138
Compare
the colors are broken in light mode (we will use light mode for all the demos) |
|
@benwolfram I pushed a quick fix fb49141 to this branch: I re-added the TestMenu (which we need for debugging and which is why the System Test was breaking), and moved it to a new place that is actually better for us. |
bkrmendy
approved these changes
Jun 21, 2024
seanparsons
approved these changes
Jul 3, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** We'd like to have a more prominent, easily-accessible way to manage panel visibility located in the toolbar **Fix:** As a v1, leveraging a lot of similarity to the insert mode's dropdown in the toolbar. Will iterate to use leverage a newly created button + dropdown menu component in the future. **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode Fixes #5892 --------- Co-authored-by: Balazs Bajorics <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We'd like to have a more prominent, easily-accessible way to manage panel visibility located in the toolbar
Fix:
As a v1, leveraging a lot of similarity to the insert mode's dropdown in the toolbar. Will iterate to use leverage a newly created button + dropdown menu component in the future.
Manual Tests:
I hereby swear that:
Fixes #5892