Clear Highlights On Other Panels #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an `onMouseEnter` handler to `GridPanelInner` which clears the highlights.
seanparsons
requested review from
gbalint,
ruggi,
balazsbajorics,
liady and
bkrmendy
#13173 Bundle Size — 62.26MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13173 |
Baseline #13171 |
|
|---|---|---|
 Initial JS |
45.32MiB(~+0.01%) |
45.32MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.6% |
21.58% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4305 |
4305 |
| Duplicate Modules |
525 |
525 |
| Duplicate Code |
31.84% |
31.84% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13173 |
Baseline #13171 |
|
|---|---|---|
| JS |
62.24MiB (~+0.01%) |
62.24MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feature/clear-highlights-on-othe... Project dashboard
balazsbajorics
approved these changes
Jun 20, 2024
ruggi
approved these changes
Jun 20, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
- Added an `onMouseEnter` handler to `GridPanelInner` which clears the highlights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Highlights end up getting stuck if the user mouses over an element and into a panel like the inspector.
Fix:
The common
GridPanelInnercomponent used by the inspector/navigator/code editor clears highlights when the mouse enters it.Commit Details:
onMouseEnterhandler toGridPanelInnerwhich clears the highlights.Manual Tests:
I hereby swear that:
Fixes #6008