Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find JSXElementChild in props #6017

Closed

Conversation

bkrmendy
Copy link
Contributor

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details: (< vv pls delete this section if's not relevant)

  • Renamed thing to otherThing
  • Removed cake from fridge-contents.ts
  • Did [other things]

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Try me

Copy link

relativeci bot commented Jun 21, 2024

#13196 Bundle Size — 62.27MiB (~+0.01%).

839025a(current) vs 6339ece master#13191(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#13196
     Baseline
#13191
Regression  Initial JS 45.33MiB(+0.01%) 45.33MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 22.47% 21.58%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4306(+0.02%) 4305
No change  Duplicate Modules 525 525
Change  Duplicate Code 31.83%(-0.03%) 31.84%
No change  Packages 448 448
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13196
     Baseline
#13191
Regression  JS 62.26MiB (~+0.01%) 62.25MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch fix/find-jsx-element-child-propsProject dashboard

@bkrmendy bkrmendy closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant