Find JSXElementChild in props #6019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13197 Bundle Size — 62.26MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13197 |
Baseline #13191 |
|
|---|---|---|
 Initial JS |
45.33MiB(~+0.01%) |
45.33MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.61% |
21.58% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4305 |
4305 |
| Duplicate Modules |
525 |
525 |
| Duplicate Code |
31.84% |
31.84% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13197 |
Baseline #13191 |
|
|---|---|---|
| JS |
62.25MiB (~+0.01%) |
62.25MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/find-jsx-element-child-in-pr... Project dashboard
seanparsons
approved these changes
Jun 21, 2024
gbalint
approved these changes
Jun 21, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Specific bug: We don't show the data reference section in the inspector when a literal-valued property is selected (like we do for literal-valued children) Inspector with literal valued child, with data reference section: <img width="1132" alt="image" src="https://github.com/concrete-utopia/utopia/assets/16385508/9c0ac596-300a-4cbd-8591-a9e16ef04cbb"> Inspector with literal-valued property, without data reference section: <img width="1355" alt="image" src="https://github.com/concrete-utopia/utopia/assets/16385508/7b4a4226-9cb2-415d-be05-f64c3922798a"> ## Cause/fix `findJSXElementChildAtPath`, the utility function called when determining whether the data reference section should be shown for a specific selected element path, only returns a non-null JSXElementChild from props only if the prop is JSXElement-valued (even though the type would accomodate literal values too). This PR removes the JSXElement restriction. The result: <img width="1133" alt="image" src="https://github.com/concrete-utopia/utopia/assets/16385508/f4d4c17a-0591-406b-ab0e-a25e5dd1d600"> ### Manual tests - [x] I swear that the Hydrogen store still loads and I can navigate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific bug:
We don't show the data reference section in the inspector when a literal-valued property is selected (like we do for literal-valued children)
Inspector with literal valued child, with data reference section:
Inspector with literal-valued property, without data reference section:
Cause/fix
findJSXElementChildAtPath, the utility function called when determining whether the data reference section should be shown for a specific selected element path, only returns a non-null JSXElementChild from props only if the prop is JSXElement-valued (even though the type would accomodate literal values too).This PR removes the JSXElement restriction.
The result:
Manual tests