-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid resize better handles #6058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrmendy
reviewed
Jul 10, 2024
#13316 Bundle Size — 62.62MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
Current #13316 |
Baseline #13302 |
|
---|---|---|
Initial JS | 45.68MiB (~+0.01% ) |
45.67MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 21.62% |
21.58% |
Chunks | 30 |
30 |
Assets | 33 |
33 |
Modules | 4350 |
4350 |
Duplicate Modules | 524 |
524 |
Duplicate Code | 31.71% |
31.71% |
Packages | 450 |
450 |
Duplicate Packages | 51 |
51 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #13316 |
Baseline #13302 |
|
---|---|---|
JS | 62.61MiB (~+0.01% ) |
62.61MiB |
HTML | 11.16KiB (-0.33% ) |
11.2KiB |
Bundle analysis report Branch feat/resize-grid-better-handles Project dashboard
balazsbajorics
approved these changes
Jul 10, 2024
# Conflicts: # editor/src/components/canvas/controls/grid-controls.tsx
bkrmendy
approved these changes
Jul 10, 2024
ruggi
added a commit
that referenced
this pull request
Jul 10, 2024
Fix for a typo in the container width calculations of #6058 which would end up being too large.
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** The resize grid strategy has some UI issues: 1. the handles are only shown when a grid cell is selected, not the grid itself 2. the handles are not positioned correctly relatively to the grid itself 3. it's hard to discern precisely the resize effects **Fix:** 1. Enable the grid resizing if the grid is selected too 2. Position the handles centered relatively to the grid rows/columns 3. Replace the "numbered handles" with more subtle draggable circles 4. During drag, show a striped background for the affected row or column, with the measurements centered in the striped area **Note** The handles icons are placeholders/ideas. | Before | After | |--------|-----------| | ![Kapture 2024-07-10 at 14 19 33](https://github.com/concrete-utopia/utopia/assets/1081051/0b310d2d-fda5-443e-b685-299556b90ef6) | ![Kapture 2024-07-10 at 14 17 58](https://github.com/concrete-utopia/utopia/assets/1081051/d6b005df-8e9b-4219-a5b6-8c976e85cc0a) |
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
Fix for a typo in the container width calculations of #6058 which would end up being too large.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The resize grid strategy has some UI issues:
Fix:
Note
The handles icons are placeholders/ideas.