Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
For projects with really bad performance, the slider control would oddly lag behind the canvas and the number control.
Note how the slider control doesn't update while the number control and the canvas do update
Diagnosis:
The slider control uses a local state to store the drag's current value. Probably because our dispatch internally uses a flushSync, this local state update was treated with a lower priority in React, and because the frame times are egregious, it never got enough idle time for a requestIdleCallback.
Fix:
note how the slider updates the same time as the number control and the canvas
By wrapping the local state update into a flushSync block, I managed to force it to update with the same priority as the rest of the editor.
Note: The frame times are still egregious, but that's a different problem.
Fixes #6009