Tweak cell resize handles #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liady
approved these changes
Jul 15, 2024
#13383 Bundle Size — 62.65MiB (~+0.01%).
Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13383 |
Baseline #13381 |
|
|---|---|---|
 Initial JS |
45.72MiB(~+0.01%) |
45.72MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.57% |
22.21% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4371 |
4371 |
| Duplicate Modules |
521 |
521 |
| Duplicate Code |
31.68% |
31.68% |
| Packages |
469 |
469 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13383 |
Baseline #13381 |
|
|---|---|---|
| JS |
62.64MiB (~+0.01%) |
62.64MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/grid-cell-resize-handles-sca... Project dashboard
bkrmendy
approved these changes
Jul 16, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** The grid cell resize handles don't scale correctly with zoom < 1, and they get off-center if the element frame is too small. **Fix:** 1. Use a different rendering strategy for the elements (position: absolute instead of grid) so they can scale more easily when the relative container frame gets tiny 2. Hide the handles if the frame is too tiny (relative to the zoom too) 3. Hide the other three inactive edge handles when resizing is in progress, so they don't look off | Before | After | |--------|------------| |  |  | | https://github.com/user-attachments/assets/d6ba7995-c73e-4715-b4a1-1efb92ae3d5d | https://github.com/user-attachments/assets/a889a07b-60fa-4519-bd37-8001ca583f35 | _I have no idea why GH is truncating those GIFs, see the mp4 attachments for reference_ Fixes #6081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The grid cell resize handles don't scale correctly with zoom < 1, and they get off-center if the element frame is too small.
Fix:
I have no idea why GH is truncating those GIFs, see the mp4 attachments for reference
Fixes #6081