Resize grid with precision modifier #6104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13447 Bundle Size — 62.64MiB (~+0.01%).
Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13447 |
Baseline #13444 |
|
|---|---|---|
 Initial JS |
45.71MiB(~+0.01%) |
45.71MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.55% |
21.53% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4376 |
4376 |
| Duplicate Modules |
524 |
524 |
| Duplicate Code |
31.69% |
31.69% |
| Packages |
469 |
469 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13447 |
Baseline #13444 |
|
|---|---|---|
| JS |
62.63MiB (~+0.01%) |
62.63MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feat/precision-modifier-resize-g... Project dashboard
editor/src/components/canvas/canvas-strategies/strategies/resize-grid-strategy.ts
Outdated
Show resolved
Hide resolved
balazsbajorics
approved these changes
Jul 22, 2024
balazsbajorics
approved these changes
Jul 22, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** It should be possible to use the `cmd` modifier key to apply a coarse precision when resizing grid cols/rows similarly to other resizing strategies. **Fix:** When `cmd` is pressed, adjust col/rows size in steps of `10` for pixel values and `.5` for fractional values. https://github.com/user-attachments/assets/cfb61a5d-8712-4082-a084-c233968d8d4d Fixes #6103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It should be possible to use the
cmdmodifier key to apply a coarse precision when resizing grid cols/rows similarly to other resizing strategies.Fix:
When
cmdis pressed, adjust col/rows size in steps of10for pixel values and.5for fractional values.Kapture.2024-07-19.at.11.36.24.mp4
Fixes #6103