Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An icon for the "Do Nothing" strategy #6112

Merged
merged 1 commit into from
Jul 23, 2024
Merged

An icon for the "Do Nothing" strategy #6112

merged 1 commit into from
Jul 23, 2024

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Jul 23, 2024 •
edited
Loading

Uploading an icon for the "Do Nothing" strategy

Screenshot 2024-07-23 at 11 02 13 AM

@lankaukk lankaukk merged commit 1ac1814 into master Jul 23, 2024
4 checks passed
@lankaukk lankaukk deleted the nothing-icon branch July 23, 2024 15:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jul 23, 2024

#13483 Bundle Size — 62.6MiB (~-0.01%).

a1800a9(current) vs 6339ece master#13473(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13483		      Baseline
#13473
Regression  Initial JS 45.67MiB(~+0.01%) 45.67MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.51% 21.69%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4375 4375
No change  Duplicate Modules 523 523
No change  Duplicate Code 31.66% 31.66%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13483		      Baseline
#13473
Regression  JS 62.59MiB (~+0.01%) 62.59MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis report Branch nothing-icon Project dashboard

bkrmendy pushed a commit that referenced this pull request Jul 24, 2024
@lankaukk @bkrmendy
An icon for the "Do Nothing" strategy (#6112)
02c015c 
Uploading an icon for the "Do Nothing" strategy

<img width="598" alt="Screenshot 2024-07-23 at 11 02 13 AM"
src="https://github.com/user-attachments/assets/e0602353-2f35-4066-8719-3a6b3fa9fa14">
liady pushed a commit that referenced this pull request Dec 13, 2024
@lankaukk @liady
An icon for the "Do Nothing" strategy (#6112)
7fc073e 
Uploading an icon for the "Do Nothing" strategy

<img width="598" alt="Screenshot 2024-07-23 at 11 02 13 AM"
src="https://github.com/user-attachments/assets/e0602353-2f35-4066-8719-3a6b3fa9fa14">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lankaukk