Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove grid children props when removing layout #6138

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Remove grid children props when removing layout #6138

merged 3 commits into from
Jul 29, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Jul 29, 2024

Followup to #6097

Problem:
When removing a grid layout, its children still contain grid-specific props after being converted to absolute, which can cause all sorts of unpredictable/unintuitive issues.

Fix:

Prune those props.

Fixes #6137

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 29, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jul 29, 2024 •
edited
Loading

#13574 Bundle Size — 62.66MiB (~+0.01%).

f9b6686(current) vs 6339ece master#13568(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13574		      Baseline
#13568
Regression  Initial JS 45.73MiB(~+0.01%) 45.73MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.58% 21.55%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4380 4380
No change  Duplicate Modules 525 525
No change  Duplicate Code 31.64% 31.64%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13574		      Baseline
#13568
Regression  JS 62.65MiB (~+0.01%) 62.65MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis report Branch fix/remove-grid-children-props Project dashboard

@gbalint
Copy link
Contributor

gbalint commented Jul 29, 2024

I would be nice to add a test (the strategy already has a browser test file)

@ruggi
Copy link
Contributor Author

ruggi commented Jul 29, 2024

I would be nice to add a test (the strategy already has a browser test file)

done in 426b008 (#6138)

@ruggi ruggi merged commit 4c44415 into master Jul 29, 2024
13 checks passed
@ruggi ruggi deleted the fix/remove-grid-children-props branch July 29, 2024 15:22
liady pushed a commit that referenced this pull request Dec 13, 2024
@ruggi @liady
Remove grid children props when removing layout (#6138)
056ce08 
Followup to #6097

**Problem:**
When removing a grid layout, its children still contain grid-specific
props after being converted to absolute, which can cause all sorts of
unpredictable/unintuitive issues.

**Fix:**

Prune those props.

Fixes #6137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@liady liady liady approved these changes

@gbalint gbalint gbalint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove grid child props
4 participants
@ruggi @gbalint @liady @bkrmendy