Resize grid cell with keyboard #6313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruggi
commented
Sep 4, 2024
editor/src/components/canvas/canvas-strategies/strategies/grid-helpers.ts
Outdated
Show resolved
Hide resolved
ruggi
commented
Sep 4, 2024
editor/src/components/canvas/canvas-strategies/strategies/grid-helpers.ts
Outdated
Show resolved
Hide resolved
#14104 Bundle Size — 62.54MiB (~+0.01%).d57e220(current) vs 916e8b9 master#14102(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14104 |
Baseline #14102 |
|
|---|---|---|
 Initial JS |
45.66MiB(~+0.01%) |
45.66MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.68% |
21.6% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4381(+0.02%) |
4380 |
| Duplicate Modules |
520(+0.19%) |
519 |
| Duplicate Code |
31.62%(+0.03%) |
31.61% |
| Packages |
472 |
472 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 2 regressions
| Current #14104 |
Baseline #14102 |
|
|---|---|---|
| JS |
62.53MiB (~+0.01%) |
62.52MiB |
| HTML |
11.12KiB (+0.27%) |
11.09KiB |
Bundle analysis report Branch feat/grid-keyboard-resize Project dashboard
Generated by RelativeCI Documentation Report issue
liady
approved these changes
Sep 4, 2024
Rheeseyb
reviewed
Sep 4, 2024
editor/src/components/canvas/canvas-strategies/strategies/grid-resize-keyboard-strategy.ts
Outdated
Show resolved
Hide resolved
bkrmendy
approved these changes
Sep 5, 2024
Rheeseyb
approved these changes
Sep 5, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** It should be possible to resize grid cells with the keyboard in addition to the mouse based counterpart. **Fix:** Expand the existing keyboard strategy with a variation that allows to resize the current selected grid cell when using the arrow keys and the `shift` modifier. In order to avoid any headaches the resize is relative to the bottom-right corner of the cell, so it's intuitive to perform resizes and subsequent moves if needed without having to worry about "which side am I resizing from?". It _is_ possible to perform both moves and resizes as part of the same interaction session.  Fixes #6312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It should be possible to resize grid cells with the keyboard in addition to the mouse based counterpart.
Fix:
Expand the existing keyboard strategy with a variation that allows to resize the current selected grid cell when using the arrow keys and the
shiftmodifier. In order to avoid any headaches the resize is relative to the bottom-right corner of the cell, so it's intuitive to perform resizes and subsequent moves if needed without having to worry about "which side am I resizing from?".It is possible to perform both moves and resizes as part of the same interaction session.
Fixes #6312