Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): remove warnings #6335

Closed
wants to merge 5 commits into from
Closed

chore(test): remove warnings #6335

wants to merge 5 commits into from

Conversation

liady
Copy link
Contributor

@liady liady commented Sep 7, 2024

Problem:
Today we have a lot of warnings in our Karma output which really clutters it

Fix:
This PR tries to address some of them:

  1. import the default export of package.json instead of import * from
  2. change moduleIds from hashed to deterministic (as Webpack recommends)
  3. import { act } from @testing-library/react instead of react-dom/test-utils

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Copy link
Contributor

github-actions bot commented Sep 7, 2024

Try me

Copy link

relativeci bot commented Sep 7, 2024

#15425 Bundle Size — 58.21MiB (-0.02%).

5696d50(current) vs d1d46c1 master#15423(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#15425
     Baseline
#15423
Improvement  Initial JS 41.18MiB(-0.03%) 41.19MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 18.14%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4190 4190
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.24% 27.24%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#15425
     Baseline
#15423
Improvement  JS 58.2MiB (-0.02%) 58.21MiB
Improvement  HTML 9.4KiB (-0.21%) 9.42KiB

Bundle analysis reportBranch chore/clear-warnsProject dashboard


Generated by RelativeCIDocumentationReport issue

@liady liady marked this pull request as ready for review December 13, 2024 17:46
@liady liady added the Spike Experiment, trial, investigation label Dec 15, 2024
@liady
Copy link
Contributor Author

liady commented Dec 16, 2024

Temporarily closing as a spike to be picked up later

@liady liady closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spike Experiment, trial, investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant